Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vlan port mappings not removed #6423

Merged
merged 1 commit into from Apr 15, 2017
Merged

Conversation

murrant
Copy link
Member

@murrant murrant commented Apr 15, 2017

Thanks to @diodo for supplying this fix.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fixes: #6420

Thanks to @diodo for supplying this fix.
@mention-bot
Copy link

Thank you for submitting a PR @murrant! We have found the following @laf and @ekoyle based on the history of these files to review this PR.

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://6423.ci.librenms.org or https://6423.ci.librenms.org

@scrutinizer-notifier
Copy link

The inspection completed: 5 updated code elements

@laf laf merged commit 924b751 into librenms:master Apr 15, 2017
laf added a commit that referenced this pull request Apr 16, 2017
laf added a commit that referenced this pull request Apr 16, 2017
* Revert "improve callback serial number regex (#6435)"

This reverts commit 2f881e3.

* Revert "fix: vlan port mappings not removed (#6423)"

This reverts commit 924b751.

* Revert "missed file deletion (#6430)"

This reverts commit 801a563.

* Revert "refactor: move Engenius discovery to yaml (#6428)"

This reverts commit fa731f3.

* Revert "refactor: move cometsystem-p85xx (#6427)"

This reverts commit 01477a1.

* Revert "refactor: move the rest of avaya os detection to yaml (#6426)"

This reverts commit 8a8edb7.

* Revert "refactor: move aos discovery to yaml (#6425)"

This reverts commit 54975f6.

* Revert "newdevice: improve IOS-XE detection (#6429)"

This reverts commit 9c44b1a.
@murrant murrant deleted the fix-vlan-removal branch April 16, 2017 13:03
@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vlan mapping not removed
5 participants