refactor: move the rest of avaya os detection to yaml #6426

Merged
merged 1 commit into from Apr 15, 2017

Conversation

Projects
None yet
5 participants
@murrant
Member

murrant commented Apr 15, 2017

Detection should be improved for these OS.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

refactor: move the rest of avaya os detection to yaml
Detection should be improved for these OS.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 15, 2017

Thank you for submitting a PR @murrant! We have found the following @laf and @Tawmu based on the history of these files to review this PR.

Thank you for submitting a PR @murrant! We have found the following @laf and @Tawmu based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 15, 2017

The inspection completed: 2 updated code elements

The inspection completed: 2 updated code elements

@laf laf merged commit 8a8edb7 into librenms:master Apr 15, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@murrant murrant deleted the murrant:avaya-yaml branch Apr 15, 2017

laf added a commit that referenced this pull request Apr 16, 2017

laf added a commit that referenced this pull request Apr 16, 2017

Revert "newdevice: improve IOS-XE detection" (#6436)
* Revert "improve callback serial number regex (#6435)"

This reverts commit 2f881e3.

* Revert "fix: vlan port mappings not removed (#6423)"

This reverts commit 924b751.

* Revert "missed file deletion (#6430)"

This reverts commit 801a563.

* Revert "refactor: move Engenius discovery to yaml (#6428)"

This reverts commit fa731f3.

* Revert "refactor: move cometsystem-p85xx (#6427)"

This reverts commit 01477a1.

* Revert "refactor: move the rest of avaya os detection to yaml (#6426)"

This reverts commit 8a8edb7.

* Revert "refactor: move aos discovery to yaml (#6425)"

This reverts commit 54975f6.

* Revert "newdevice: improve IOS-XE detection (#6429)"

This reverts commit 9c44b1a.

@librenms librenms locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.