New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix alerts not honouring interval over 5m #6438

Merged
merged 1 commit into from Apr 18, 2017

Conversation

Projects
None yet
4 participants
@laf
Member

laf commented Apr 17, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

A change I made 25 days ago broke repeat notifications when the interval was > 5m.

This resolves this now (tested in the community forum and I've tested with 10 m intervals). I think some of the overall logic is broken in alerting so we need to address it at some stage.

https://community.librenms.org/t/problem-with-alert-system/1015/6

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 17, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @f0o and @FTBZ based on the history of these files to review this PR.

mention-bot commented Apr 17, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @f0o and @FTBZ based on the history of these files to review this PR.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 17, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Apr 17, 2017

The inspection completed: No new issues

@murrant murrant merged commit 0b2f5cd into librenms:master Apr 18, 2017

1 of 2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:fix/community-1015 branch Apr 18, 2017

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.