New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow line returns in snmprec files with the 4x data type #6443

Merged
merged 2 commits into from Apr 18, 2017

Conversation

Projects
None yet
4 participants
@murrant
Member

murrant commented Apr 18, 2017

Fill in IOS data files
IOS-XE discovery fails, fix that

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

issue: #6434

fix: Allow line returns in snmprec files with the 4x data type
Fill in IOS data files
IOS-XE discovery fails, fix that
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 18, 2017

Thank you for submitting a PR @murrant! We have found the following @laf, @Rosiak and @geordish based on the history of these files to review this PR.

mention-bot commented Apr 18, 2017

Thank you for submitting a PR @murrant! We have found the following @laf, @Rosiak and @geordish based on the history of these files to review this PR.

@murrant murrant added Discovery and removed Discovery labels Apr 18, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 18, 2017

The inspection completed: 13 new issues

scrutinizer-notifier commented Apr 18, 2017

The inspection completed: 13 new issues

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Apr 18, 2017

Member

No better way to do this to leave the test units human readable? Is it the detection that breaks or the test units that break without this?

Member

laf commented Apr 18, 2017

No better way to do this to leave the test units human readable? Is it the detection that breaks or the test units that break without this?

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Apr 18, 2017

Member

Tests are incorrect without this, which allowed the incorrect detection to slip through this weekend. Unfortunately, no way to keep it human readable and stay compatible with snmpsim.

I did change it so it will print out the decoded string if tests fail.

Member

murrant commented Apr 18, 2017

Tests are incorrect without this, which allowed the incorrect detection to slip through this weekend. Unfortunately, no way to keep it human readable and stay compatible with snmpsim.

I did change it so it will print out the decoded string if tests fail.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Apr 18, 2017

Member

:(

Member

laf commented Apr 18, 2017

:(

@laf laf merged commit 963f444 into librenms:master Apr 18, 2017

1 of 2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@murrant murrant deleted the murrant:ios-linereturns branch Apr 18, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.