New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: allow _except suffix in yaml os discovery #6444

Merged
merged 1 commit into from Apr 18, 2017

Conversation

Projects
None yet
4 participants
@murrant
Member

murrant commented Apr 18, 2017

Negates the selected check

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

issue: #6434

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 18, 2017

Thank you for submitting a PR @murrant! We have found the following @laf, @zarya and @tuxis-ie based on the history of these files to review this PR.

mention-bot commented Apr 18, 2017

Thank you for submitting a PR @murrant! We have found the following @laf, @zarya and @tuxis-ie based on the history of these files to review this PR.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 18, 2017

The inspection completed: 166 new issues, 1 updated code elements

scrutinizer-notifier commented Apr 18, 2017

The inspection completed: 166 new issues, 1 updated code elements

@laf laf merged commit b4c4c39 into librenms:master Apr 18, 2017

1 of 2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@murrant murrant deleted the murrant:yaml-except branch Apr 18, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.