New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: only run pre-cache for the current OS #6453

Merged
merged 1 commit into from Apr 18, 2017

Conversation

Projects
None yet
4 participants
@murrant
Member

murrant commented Apr 18, 2017

Change powerwalker to use the $pre_cache array
Tested with poweralert and comware

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

refactor: only run pre-cache for the current OS
Change powerwalker to use the $pre_cache array
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 18, 2017

Thank you for submitting a PR @murrant! We have found the following @laf and @remydb based on the history of these files to review this PR.

Thank you for submitting a PR @murrant! We have found the following @laf and @remydb based on the history of these files to review this PR.

@laf

laf approved these changes Apr 18, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 18, 2017

The inspection completed: No new issues

The inspection completed: No new issues

@laf laf merged commit c88c677 into librenms:master Apr 18, 2017

1 of 2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@murrant murrant deleted the murrant:discovery-includes branch Apr 18, 2017

@murrant murrant referenced this pull request Apr 18, 2017

Closed

fix: Don't run ipoman sensor disco on every device #6441

2 of 2 tasks complete
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.