New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Added support for Eltex OLT devices #6457

Merged
merged 1 commit into from Apr 22, 2017

Conversation

Projects
None yet
3 participants
@laf
Member

laf commented Apr 18, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

  • Can't find ram info. ltp8xRAMFree is the closest but it has no total ram counterpart!
  • Claims that interface speeds aren't correct but no info in the issue - most likely needs to be addressed by vendor as HC info is there.
  • Assumed that ltp8xCPULoadAverage5Minutes needed to be divided by 10 as the values in the test data were 240~.

Fixes: #6321

image

@laf laf added the Device 🖥 label Apr 18, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 18, 2017

The inspection completed: 1 updated code elements

The inspection completed: 1 updated code elements

@murrant murrant merged commit b27e200 into librenms:master Apr 22, 2017

2 of 3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:device/issue-6321 branch Apr 22, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.