New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated enterasys mempools disco/polling to support multiple ram… #6458

Merged
merged 1 commit into from Apr 19, 2017

Conversation

Projects
None yet
4 participants
@laf
Member

laf commented Apr 18, 2017

… devices

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

This is now changed to dynamically discover the memory for enterasys. Existing mempools will break as it uses an index value of 0 which seems to not be valid in the snmp output. I'll happily do a notification for this.

Fixes: #6225

@laf laf added the Bug 🐞 label Apr 18, 2017

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 18, 2017

Thank you for submitting a PR @laf! We have found the following @geordish based on the history of these files to review this PR.

mention-bot commented Apr 18, 2017

Thank you for submitting a PR @laf! We have found the following @geordish based on the history of these files to review this PR.

@laf laf referenced this pull request Apr 18, 2017

Closed

Incomplete CPU and RAM graphing on Enterasys N-series switches #6225

4 of 4 tasks complete
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 18, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Apr 18, 2017

The inspection completed: No new issues

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Apr 19, 2017

Member

PR confirmed working in the issue raised. Let me know if people think we need a notification for this.

Member

laf commented Apr 19, 2017

PR confirmed working in the issue raised. Let me know if people think we need a notification for this.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Apr 19, 2017

Member

I think users that are working right now will continue to work right?

Member

murrant commented Apr 19, 2017

I think users that are working right now will continue to work right?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Apr 19, 2017

Member

I'm not 100% sure it will but have no devices to test :(

Member

laf commented Apr 19, 2017

I'm not 100% sure it will but have no devices to test :(

@murrant murrant merged commit 75d62aa into librenms:master Apr 19, 2017

1 of 2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:fix/issue-6225 branch Apr 19, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.