New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Service filenames are snipped when longer than 16 characters #6459

Merged
merged 13 commits into from Apr 19, 2017

Conversation

Projects
None yet
4 participants
@aldemira
Contributor

aldemira commented Apr 19, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 19, 2017

Thank you for submitting a PR @aldemira! We have found the following @laf and @xbeaudouin based on the history of these files to review this PR.

mention-bot commented Apr 19, 2017

Thank you for submitting a PR @aldemira! We have found the following @laf and @xbeaudouin based on the history of these files to review this PR.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Apr 19, 2017

Member

I've rebased this, let's see if that fixes travis.

Member

laf commented Apr 19, 2017

I've rebased this, let's see if that fixes travis.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Apr 19, 2017

Member

Attempt 2.

Member

laf commented Apr 19, 2017

Attempt 2.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 19, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Apr 19, 2017

The inspection completed: No new issues

@laf laf merged commit 450c980 into librenms:master Apr 19, 2017

1 of 2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.