New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updated install docs + perf to support compressing file types and using http/2 #6466

Merged
merged 1 commit into from Apr 22, 2017

Conversation

Projects
None yet
4 participants
@laf
Member

laf commented Apr 19, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

I'm not sure all these file types are needed but I've added more JS to be compressed which helps with page load times. Standardised the file types across apache + nginx.

Added an entry to Performance docs to say to enable http/2 where possible.

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 19, 2017

Thank you for submitting a PR @laf! We have found the following @Gorian, @sorano and @jodumont based on the history of these files to review this PR.

mention-bot commented Apr 19, 2017

Thank you for submitting a PR @laf! We have found the following @Gorian, @sorano and @jodumont based on the history of these files to review this PR.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 19, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Apr 19, 2017

The inspection completed: No new issues

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Apr 22, 2017

Member

Nice :)

Member

murrant commented Apr 22, 2017

Nice :)

@murrant murrant merged commit 64e020d into librenms:master Apr 22, 2017

2 of 3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:docs/perf-compression branch Apr 22, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.