New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

location map regex replace pattern only #6485

Merged
merged 6 commits into from Apr 24, 2017

Conversation

Projects
None yet
7 participants
@MrDragon
Contributor

MrDragon commented Apr 20, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 20, 2017

Thank you for submitting a PR @MrDragon! We have found the following @murrant, @laf and @crcro based on the history of these files to review this PR.

mention-bot commented Apr 20, 2017

Thank you for submitting a PR @MrDragon! We have found the following @murrant, @laf and @crcro based on the history of these files to review this PR.

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Apr 20, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Apr 20, 2017

CLA assistant check
All committers have signed the CLA.

@MrDragon

This comment has been minimized.

Show comment
Hide comment
@MrDragon

MrDragon Apr 20, 2017

Contributor

I don't know if I did anything right... See https://community.librenms.org/t/location-mapping-regex-substitute/1054/3 - that's my submission, use it as you see fit :)

Contributor

MrDragon commented Apr 20, 2017

I don't know if I did anything right... See https://community.librenms.org/t/location-mapping-regex-substitute/1054/3 - that's my submission, use it as you see fit :)

@MrDragon MrDragon closed this Apr 20, 2017

@MrDragon MrDragon reopened this Apr 20, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Apr 20, 2017

Auto-Deploy finished, Test PR at http://6485.ci.librenms.org or https://6485.ci.librenms.org

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Apr 22, 2017

Member

Looks good!

I think this needs some documentation updates and you need to fix the one style issue.

Member

murrant commented Apr 22, 2017

Looks good!

I think this needs some documentation updates and you need to fix the one style issue.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf
Member

laf commented Apr 22, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Apr 22, 2017

Auto-Deploy finished, Test PR at http://6485.ci.librenms.org or https://6485.ci.librenms.org

Update Configuration.md
Adding "location_map_regex_sub" documentation
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Apr 22, 2017

Auto-Deploy finished, Test PR at http://6485.ci.librenms.org or https://6485.ci.librenms.org

@MrDragon

This comment has been minimized.

Show comment
Hide comment
@MrDragon

MrDragon Apr 22, 2017

Contributor

Thank you for pointing me at the docs. As to the style issue, I did find two lines with trailing spaces (fixed). If there's another style issue, I may need a bigger hint :(
Thank you for your patience and guidance!

Contributor

MrDragon commented Apr 22, 2017

Thank you for pointing me at the docs. As to the style issue, I did find two lines with trailing spaces (fixed). If there's another style issue, I may need a bigger hint :(
Thank you for your patience and guidance!

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Apr 24, 2017

Member

imho it needs a bit more clarity in the docs, I can't tell from the example what it's doing.

Member

laf commented Apr 24, 2017

imho it needs a bit more clarity in the docs, I can't tell from the example what it's doing.

Update Configuration.md
Better(?) example/explanation for location_map_regex_sub.
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Apr 24, 2017

Auto-Deploy finished, Test PR at http://6485.ci.librenms.org or https://6485.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Apr 24, 2017

Auto-Deploy finished, Test PR at http://6485.ci.librenms.org or https://6485.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 24, 2017

The inspection completed: 1 updated code elements

scrutinizer-notifier commented Apr 24, 2017

The inspection completed: 1 updated code elements

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Apr 24, 2017

Auto-Deploy finished, Test PR at http://6485.ci.librenms.org or https://6485.ci.librenms.org

@laf laf merged commit dcc6c96 into librenms:master Apr 24, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@MrDragon MrDragon deleted the MrDragon:MrDragon-patch-1 branch Aug 16, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.