newdevice: Etherwan managed switches #6488

Merged
merged 2 commits into from Apr 22, 2017

Conversation

Projects
None yet
6 participants
@EnzoZafra
Contributor

EnzoZafra commented Apr 20, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 20, 2017

Thank you for submitting a PR @EnzoZafra! We have found the following @laf, @murrant and @Rosiak based on the history of these files to review this PR.

Thank you for submitting a PR @EnzoZafra! We have found the following @laf, @murrant and @Rosiak based on the history of these files to review this PR.

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Apr 20, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Apr 20, 2017

CLA assistant check
All committers have signed the CLA.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Apr 20, 2017

Member

Do all of the switches Etherwan provide run the same OS/Firmware? If not then I'd say the OS name should be updated to be less generic here.

Member

laf commented Apr 20, 2017

Do all of the switches Etherwan provide run the same OS/Firmware? If not then I'd say the OS name should be updated to be less generic here.

@EnzoZafra

This comment has been minimized.

Show comment
Hide comment
@EnzoZafra

EnzoZafra Apr 20, 2017

Contributor

Didn't find much online however I know they supply one MIB for all their switches. The MIB used to be called Etherwan SW72000 which is not a name for any of their hardware so maybe its what they call their OS? Their MIBs are now called 'ewnSwitchM' (Etherwan Switch Management ?) though

Contributor

EnzoZafra commented Apr 20, 2017

Didn't find much online however I know they supply one MIB for all their switches. The MIB used to be called Etherwan SW72000 which is not a name for any of their hardware so maybe its what they call their OS? Their MIBs are now called 'ewnSwitchM' (Etherwan Switch Management ?) though

includes/definitions/etherwan.yaml
+ - { graph: device_processor, text: 'CPU Usage' }
+discovery:
+ - sysObjectId:
+ - .1.3.6.1.4.1.2736.1.1

This comment has been minimized.

@laf

laf Apr 20, 2017

Member

We have nothing in stats for this OID, I'd be inclined to change it to .1.3.6.1.4.1.2736.

@laf

laf Apr 20, 2017

Member

We have nothing in stats for this OID, I'd be inclined to change it to .1.3.6.1.4.1.2736.

includes/polling/os/etherwan.inc.php
+ * @author Lorenzo Zafra<zafra@ualberta.ca>
+ */
+
+// SNMPv2-MIB::sysDescr.0 = STRING: Etherwan 6TX+2G Managed Switch, Firmware rev: 1.94.3 05/11/15 16:31:18

This comment has been minimized.

@laf

laf Apr 20, 2017

Member

Can remove that, we have the test data.

@laf

laf Apr 20, 2017

Member

Can remove that, we have the test data.

includes/polling/os/etherwan.inc.php
+
+// SNMPv2-MIB::sysDescr.0 = STRING: Etherwan 6TX+2G Managed Switch, Firmware rev: 1.94.3 05/11/15 16:31:18
+
+$description = $poll_device['sysDescr'];

This comment has been minimized.

@laf

laf Apr 20, 2017

Member

No point in assigning this variable, just use $poll_device['sysDescr'] directly below

@laf

laf Apr 20, 2017

Member

No point in assigning this variable, just use $poll_device['sysDescr'] directly below

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 21, 2017

The inspection completed: 10 new issues, 1 updated code elements

The inspection completed: 10 new issues, 1 updated code elements

@laf laf merged commit c31bc7d into librenms:master Apr 22, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@EnzoZafra EnzoZafra deleted the EnzoZafra:issue-6487 branch Jun 14, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@librenms librenms locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.