New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: sdfsinfo #6494

Merged
merged 11 commits into from Apr 27, 2017

Conversation

Projects
None yet
5 participants
@crcro
Contributor

crcro commented Apr 23, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

sdfs info app for sdfs dedup volume
requires librenms/librenms-agent#122

screen shot 2017-04-23 at 5 48 34 pm

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 23, 2017

Thank you for submitting a PR @crcro! We have found the following @murrant, @laf and @VVelox based on the history of these files to review this PR.

mention-bot commented Apr 23, 2017

Thank you for submitting a PR @crcro! We have found the following @murrant, @laf and @VVelox based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Apr 23, 2017

Auto-Deploy finished, Test PR at http://6494.ci.librenms.org or https://6494.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Apr 23, 2017

Auto-Deploy finished, Test PR at http://6494.ci.librenms.org or https://6494.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Apr 23, 2017

Auto-Deploy finished, Test PR at http://6494.ci.librenms.org or https://6494.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Apr 23, 2017

Auto-Deploy finished, Test PR at http://6494.ci.librenms.org or https://6494.ci.librenms.org

Show outdated Hide outdated doc/Extensions/Applications.md
@@ -35,6 +35,7 @@ Different applications support a variety of ways collect data: by direct connect
1. [Unbound](#unbound) - Agent
1. [UPS-nut](#ups-nut) - SNMP extend
1. [UPS-apcups](#ups-apcups) - SNMP extend
1. [SDFS info](#sdfs-info) - SNMP extend

This comment has been minimized.

@laf

laf Apr 24, 2017

Member

These should be alphabetical :)

@laf

laf Apr 24, 2017

Member

These should be alphabetical :)

Show outdated Hide outdated doc/Extensions/Applications.md
### SDFS info
A small shell script (written in PHP) that exportfs SDFS volume info.

This comment has been minimized.

@laf

laf Apr 24, 2017

Member

No longer php :)

@laf

laf Apr 24, 2017

Member

No longer php :)

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Apr 24, 2017

Auto-Deploy finished, Test PR at http://6494.ci.librenms.org or https://6494.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Apr 26, 2017

Auto-Deploy finished, Test PR at http://6494.ci.librenms.org or https://6494.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Apr 26, 2017

Auto-Deploy finished, Test PR at http://6494.ci.librenms.org or https://6494.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 26, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Apr 26, 2017

The inspection completed: No new issues

Show outdated Hide outdated doc/Extensions/Applications.md
A small shell script that exportfs SDFS volume info.
###### SNMP Extend
1. Copy the [sdfsinfo](https://github.com/librenms/librenms-agent/blob/master/snmp/sdfsinfo) to `/etc/snmp/` on SDFS enabled host.

This comment has been minimized.

@laf

laf Apr 27, 2017

Member

Last comment from me I think, you should put the curl command like in the other instructions so people can just copy / paste.

@laf

laf Apr 27, 2017

Member

Last comment from me I think, you should put the curl command like in the other instructions so people can just copy / paste.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Apr 27, 2017

Auto-Deploy finished, Test PR at http://6494.ci.librenms.org or https://6494.ci.librenms.org

@laf laf merged commit 238ca02 into librenms:master Apr 27, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@crcro crcro deleted the crcro:sdfs-app branch Jul 9, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.