New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated ipv4/ipv6 discovery to exclude IPs with invalid port_ids #6495

Merged
merged 3 commits into from Apr 25, 2017

Conversation

Projects
None yet
5 participants
@laf
Member

laf commented Apr 23, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

We just check we have a valid port_id before we carry on, this should clear out stale entries if the device still exists in librenms.

Fixes: #6302

@laf laf added the Bug 🐞 label Apr 23, 2017

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 23, 2017

Thank you for submitting a PR @laf! We have found the following @HenocKA, @murrant and @InsaneSplash based on the history of these files to review this PR.

mention-bot commented Apr 23, 2017

Thank you for submitting a PR @laf! We have found the following @HenocKA, @murrant and @InsaneSplash based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Apr 23, 2017

Auto-Deploy finished, Test PR at http://6495.ci.librenms.org or https://6495.ci.librenms.org

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Apr 24, 2017

Member

What IP address are you removing with this? Other than that question the code change looks straight forward enough.

Member

murrant commented Apr 24, 2017

What IP address are you removing with this? Other than that question the code change looks straight forward enough.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Apr 24, 2017

Member

Ones that don't have a valid port id

Member

laf commented Apr 24, 2017

Ones that don't have a valid port id

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Apr 25, 2017

Member

Sorry, I mean I don't understand what kind of ips would not have a valid port id and why I wouldn't want them.

Perhaps ports in badif?

Member

murrant commented Apr 25, 2017

Sorry, I mean I don't understand what kind of ips would not have a valid port id and why I wouldn't want them.

Perhaps ports in badif?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Apr 25, 2017

Member

Probably would have helped if I'd have linked to #6302

Member

laf commented Apr 25, 2017

Probably would have helped if I'd have linked to #6302

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Apr 25, 2017

Member

Sure would have ;)

Member

murrant commented Apr 25, 2017

Sure would have ;)

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Apr 25, 2017

Member

Oh, it was an issue I created 😊

I don't think this fixes the problem. I think the problem is in the $valid cleanup.

Member

murrant commented Apr 25, 2017

Oh, it was an issue I created 😊

I don't think this fixes the problem. I think the problem is in the $valid cleanup.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Apr 25, 2017

Auto-Deploy finished, Test PR at http://6495.ci.librenms.org or https://6495.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Apr 25, 2017

Auto-Deploy finished, Test PR at http://6495.ci.librenms.org or https://6495.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 25, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Apr 25, 2017

The inspection completed: No new issues

@laf laf merged commit 66b7077 into librenms:master Apr 25, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:fix/issue-6302 branch Apr 25, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.