New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont run ipmitool without knowing a type - issue #6503 #6504

Merged
merged 1 commit into from Apr 25, 2017

Conversation

Projects
None yet
5 participants
@tsumaru720
Contributor

tsumaru720 commented Apr 25, 2017

Per commit message - dont run ipmitool unless we've discovered an ipmi interface to use.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #6503

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 25, 2017

Thank you for submitting a PR @tsumaru720! We have found the following @laf, @svennd and @murrant based on the history of these files to review this PR.

mention-bot commented Apr 25, 2017

Thank you for submitting a PR @tsumaru720! We have found the following @laf, @svennd and @murrant based on the history of these files to review this PR.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 25, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Apr 25, 2017

The inspection completed: No new issues

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Apr 25, 2017

Auto-Deploy finished, Test PR at http://6504.ci.librenms.org or https://6504.ci.librenms.org

@laf laf merged commit 6c6499c into librenms:master Apr 25, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@tsumaru720 tsumaru720 deleted the tsumaru720:ipmi_poll branch Apr 25, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.