New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Actually reload oxidized when we should not when we think we should #6515

Merged
merged 1 commit into from Apr 28, 2017

Conversation

Projects
None yet
5 participants
@laf
Member

laf commented Apr 27, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #3592

In the end managed to replicate this so I'm confident this fix works + added support for reloading when deleting devices.

The short of it is, I don't think the OS had been discovered by the time the API call was made from Oxidized back to LibreNMS to tell it a new device was ready. This call is now done when new device discovery is called so every 5 mins which I think is acceptable. It's probably possible to move the call somewhere else but where it was before was pretty much at the end of the process of adding a new device anyway, the only other place would be in addHost() but I don't think it will make a difference.

@laf laf added the Bug 🐞 label Apr 27, 2017

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 27, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @tuxis-ie and @zarya based on the history of these files to review this PR.

mention-bot commented Apr 27, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @tuxis-ie and @zarya based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Apr 27, 2017

Auto-Deploy finished, Test PR at http://6515.ci.librenms.org or https://6515.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 27, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Apr 27, 2017

The inspection completed: No new issues

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Apr 28, 2017

Member

Awesome!

image

Member

murrant commented Apr 28, 2017

Awesome!

image

@murrant murrant merged commit 153f0de into librenms:master Apr 28, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:fix/issue-3592 branch Apr 28, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.