New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added more safety checking into create_state_index() so we do no… #6516

Merged
merged 1 commit into from Apr 28, 2017

Conversation

Projects
None yet
5 participants
@laf
Member

laf commented Apr 27, 2017

…t end up with stale state names but no translation

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

This may really only affect people who test PRs but I've been hit with it a fair few times. It's a safety check that we have the data we need and if not force the sensor file to add it as if it's new.

Fixes: #6512

fix: Added more safety checking into create_state_index() so we do no…
…t end up with stale state names but no translation

@laf laf added the Bug 🐞 label Apr 27, 2017

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 27, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @zarya and @tuxis-ie based on the history of these files to review this PR.

mention-bot commented Apr 27, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @zarya and @tuxis-ie based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Apr 27, 2017

Auto-Deploy finished, Test PR at http://6516.ci.librenms.org or https://6516.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 27, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Apr 27, 2017

The inspection completed: No new issues

@murrant murrant merged commit d67d62e into librenms:master Apr 28, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:fix/issue-6512 branch Apr 28, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.