New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inconsistent device discovery #6518

Merged
merged 1 commit into from Apr 28, 2017

Conversation

Projects
None yet
5 participants
@murrant
Member

murrant commented Apr 28, 2017

There were two or more separate $device arrays during discovery. When one was updated, others were not.
Combine those all.
Make sure the new os is loaded if the os changed.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fix: inconsistent device discovery
There were two or more separate $device arrays during discovery. When one was updated, others were not.
Combine those all.
Make sure the new os is loaded if the os changed.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 28, 2017

Thank you for submitting a PR @murrant! We have found the following @laf, @HenocKA and @InsaneSplash based on the history of these files to review this PR.

mention-bot commented Apr 28, 2017

Thank you for submitting a PR @murrant! We have found the following @laf, @HenocKA and @InsaneSplash based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Apr 28, 2017

Auto-Deploy finished, Test PR at http://6518.ci.librenms.org or https://6518.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 28, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Apr 28, 2017

The inspection completed: No new issues

@murrant murrant added the Bug 🐞 label Apr 28, 2017

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Apr 28, 2017

Member

To reproduce this add a device and run discovery. The most obvious thing is the OS gets set and the icon changes to generic.

I was just changing the community on my snmpsim for testing.

Member

murrant commented Apr 28, 2017

To reproduce this add a device and run discovery. The most obvious thing is the OS gets set and the icon changes to generic.

I was just changing the community on my snmpsim for testing.

@laf laf merged commit 374a404 into librenms:master Apr 28, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:fix-device-array branch Apr 28, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.