New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more sensors for Exalt ExtendAir devices #6531

Merged
merged 1 commit into from May 3, 2017

Conversation

Projects
None yet
5 participants
@laf
Member

laf commented Apr 30, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Apr 30, 2017

Auto-Deploy finished, Test PR at http://6531.ci.librenms.org or https://6531.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 30, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Apr 30, 2017

The inspection completed: No new issues

if ($state_index_id !== null) {
$states = array(
array($state_index_id,'almNORMAL',1,0,0) ,

This comment has been minimized.

@Rosiak

Rosiak Apr 30, 2017

Contributor

Wouldn't it be worth to consolidate the state translations, in this case, as they practically all are the same?

@Rosiak

Rosiak Apr 30, 2017

Contributor

Wouldn't it be worth to consolidate the state translations, in this case, as they practically all are the same?

This comment has been minimized.

@laf

laf May 1, 2017

Member

You mean one state name?

@laf

laf May 1, 2017

Member

You mean one state name?

@esorin0

This comment has been minimized.

Show comment
Hide comment

esorin0 commented May 2, 2017

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 2, 2017

Member

According to that output, the two new sensors have been detected. What's actually wrong for you?

Member

laf commented May 2, 2017

According to that output, the two new sensors have been detected. What's actually wrong for you?

@esorin0

This comment has been minimized.

Show comment
Hide comment
@esorin0

esorin0 May 2, 2017

I have just posted the output, nothing is wrong.
You've added Frequency (MHz), which is something that is not really changing for a radio of this type and it's not really useful. Same with 'Link security status' state, which is a constant for a given link. Can we show TX/RX power on the device main page? Thanks!

esorin0 commented May 2, 2017

I have just posted the output, nothing is wrong.
You've added Frequency (MHz), which is something that is not really changing for a radio of this type and it's not really useful. Same with 'Link security status' state, which is a constant for a given link. Can we show TX/RX power on the device main page? Thanks!

@laf laf merged commit 568a2bf into librenms:master May 3, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:device/issue-6327-2 branch May 3, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.