New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Cisco's AsyncOS #6545

Merged
merged 9 commits into from May 2, 2017

Conversation

Projects
None yet
4 participants
@network-guy
Contributor

network-guy commented May 1, 2017

This has been tested on the Web Security Appliance, version 10+. It should work with the E-mail Security Appliances and should be backwards compatible at least to version 9.0.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

network-guy added some commits Apr 25, 2017

Create asyncos.yaml
Added device definition for AsyncOS devices.
Create asyncos.inc.php
Add poller definition for Async devices.
Update asyncos.yaml
Added discovery modules.
Update asyncos.inc.php
Refactored version, hardware, and serial parsers.
Add AsyncOS MIBs
Add MIBs for AsyncOS WSA and ESA appliances.
@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant May 1, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented May 1, 2017

CLA assistant check
All committers have signed the CLA.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 1, 2017

Member

This needs unit tests adding as well: http://docs.librenms.org/Developing/os/Test-Units/

Member

laf commented May 1, 2017

This needs unit tests adding as well: http://docs.librenms.org/Developing/os/Test-Units/

network-guy added some commits May 1, 2017

@network-guy

This comment has been minimized.

Show comment
Hide comment
@network-guy

network-guy May 1, 2017

Contributor

Should be added now. Had some issues with Git, but I think I got them worked out.

Contributor

network-guy commented May 1, 2017

Should be added now. Had some issues with Git, but I think I got them worked out.

Show outdated Hide outdated includes/polling/os/asyncos.inc.php
@@ -20,3 +20,7 @@
preg_match('/[[\w]+-[\w]+/', $serial, $regexp_results);
$serial = $regexp_results[0];
<<<<<<< HEAD

This comment has been minimized.

@laf

laf May 1, 2017

Member

This needs removing :)

@laf

laf May 1, 2017

Member

This needs removing :)

Show outdated Hide outdated tests/snmpsim/asyncos.snmprec
@@ -0,0 +1,2 @@
1.3.6.1.2.1.1.1.0|4|Cisco Model S390, AsyncOS Version: 10.1.1-230, Build Date: 2017-03-15, Serial #: 006BF1CD6AE0-FCH2044V0YB

This comment has been minimized.

@laf

laf May 1, 2017

Member

If this is a valid serial # considering changing it.

@laf

laf May 1, 2017

Member

If this is a valid serial # considering changing it.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 1, 2017

Member

Thanks, just my comment on the serial number now.

Member

laf commented May 1, 2017

Thanks, just my comment on the serial number now.

@network-guy

This comment has been minimized.

Show comment
Hide comment
@network-guy

network-guy May 1, 2017

Contributor

Changed, thanks.

Contributor

network-guy commented May 1, 2017

Changed, thanks.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier May 1, 2017

The inspection completed: 1 updated code elements

scrutinizer-notifier commented May 1, 2017

The inspection completed: 1 updated code elements

@laf

laf approved these changes May 2, 2017

@laf laf merged commit 371c0ff into librenms:master May 2, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@network-guy network-guy deleted the network-guy:AsyncOS-Support branch May 2, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.