New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AKCP SecurityProbe #6550

Merged
merged 2 commits into from May 2, 2017

Conversation

Projects
None yet
7 participants
@olivierbeytrison
Contributor

olivierbeytrison commented May 2, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot May 2, 2017

Thank you for submitting a PR @olivierbeytrison! We have found the following @laf based on the history of these files to review this PR.

mention-bot commented May 2, 2017

Thank you for submitting a PR @olivierbeytrison! We have found the following @laf based on the history of these files to review this PR.

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant May 2, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented May 2, 2017

CLA assistant check
All committers have signed the CLA.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 2, 2017

Auto-Deploy finished, Test PR at http://6550.ci.librenms.org or https://6550.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 2, 2017

Auto-Deploy finished, Test PR at http://6550.ci.librenms.org or https://6550.ci.librenms.org

@laf laf added the Device 🖥 label May 2, 2017

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant May 2, 2017

Member

You need to add another snmprec file tests/snmpsim/akcp-securityprobe.snmprec with sysObjectID and sysDescr in it and update tests/OSDiscovery.php. Otherwise, we could break this detection on accident.

Member

murrant commented May 2, 2017

You need to add another snmprec file tests/snmpsim/akcp-securityprobe.snmprec with sysObjectID and sysDescr in it and update tests/OSDiscovery.php. Otherwise, we could break this detection on accident.

@olivierbeytrison

This comment has been minimized.

Show comment
Hide comment
@olivierbeytrison

olivierbeytrison May 2, 2017

Contributor

okay, i'll do it

Contributor

olivierbeytrison commented May 2, 2017

okay, i'll do it

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 2, 2017

Auto-Deploy finished, Test PR at http://6550.ci.librenms.org or https://6550.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 2, 2017

Auto-Deploy finished, Test PR at http://6550.ci.librenms.org or https://6550.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier May 2, 2017

The inspection completed: 1 updated code elements

scrutinizer-notifier commented May 2, 2017

The inspection completed: 1 updated code elements

@laf laf merged commit a6eca49 into librenms:master May 2, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.