New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GE UPS (#6549) #6553

Merged
merged 2 commits into from May 2, 2017

Conversation

Projects
None yet
4 participants
@olivierbeytrison
Contributor

olivierbeytrison commented May 2, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented May 2, 2017

Auto-Deploy finished, Test PR at http://6553.ci.librenms.org or https://6553.ci.librenms.org

Show outdated Hide outdated includes/definitions/ge-digitalenergy.yaml
-
sysObjectId:
- .1.3.6.1.4.1.818.1.100.1.1
sysDescr_regex:

This comment has been minimized.

@laf

laf May 2, 2017

Member

Do you need this as well? Using just sysObjectId on it's own is the preferred way unless this OID conflicts with another OS

@laf

laf May 2, 2017

Member

Do you need this as well? Using just sysObjectId on it's own is the preferred way unless this OID conflicts with another OS

This comment has been minimized.

@olivierbeytrison

olivierbeytrison May 2, 2017

Contributor

I don't think it would lead to conflicts to remove it.

Being new to librenms I'm slowly getting my hands on the code ;)

@olivierbeytrison

olivierbeytrison May 2, 2017

Contributor

I don't think it would lead to conflicts to remove it.

Being new to librenms I'm slowly getting my hands on the code ;)

Show outdated Hide outdated includes/definitions/ge-digitalenergy.yaml
@@ -0,0 +1,16 @@
os: ge-digitalenergy

This comment has been minimized.

@laf

laf May 2, 2017

Member

Is this the best name for the os? It's usually based on the firmware or actual OS the device runs like IOS, JunOS, etc. If it is then that's not an issue.

@laf

laf May 2, 2017

Member

Is this the best name for the os? It's usually based on the firmware or actual OS the device runs like IOS, JunOS, etc. If it is then that's not an issue.

This comment has been minimized.

@olivierbeytrison

olivierbeytrison May 2, 2017

Contributor

tbh I don't even think there's an OS behind it. It's a simple extension card in the UPS to provide basic SNMP support. it could be changed to ge-ups

@olivierbeytrison

olivierbeytrison May 2, 2017

Contributor

tbh I don't even think there's an OS behind it. It's a simple extension card in the UPS to provide basic SNMP support. it could be changed to ge-ups

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented May 2, 2017

Auto-Deploy finished, Test PR at http://6553.ci.librenms.org or https://6553.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier May 2, 2017

The inspection completed: 1 updated code elements

scrutinizer-notifier commented May 2, 2017

The inspection completed: 1 updated code elements

@laf laf merged commit 2f5a174 into librenms:master May 2, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@olivierbeytrison olivierbeytrison deleted the olivierbeytrison:add-ge-ups branch May 2, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.