New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: improve Extremeware and XOS detection #6554

Merged
merged 1 commit into from May 3, 2017

Conversation

Projects
None yet
5 participants
@murrant
Member

murrant commented May 2, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot May 2, 2017

Thank you for submitting a PR @murrant! We have found the following @laf, @Rosiak and @EnzoZafra based on the history of these files to review this PR.

mention-bot commented May 2, 2017

Thank you for submitting a PR @murrant! We have found the following @laf, @Rosiak and @EnzoZafra based on the history of these files to review this PR.

@murrant murrant changed the title from newdevice: fix Extremeware and XOS detection to newdevice: improve Extremeware and XOS detection May 2, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented May 2, 2017

Auto-Deploy finished, Test PR at http://6554.ci.librenms.org or https://6554.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier May 2, 2017

The inspection completed: No new issues

scrutinizer-notifier commented May 2, 2017

The inspection completed: No new issues

- sysObjectId:
- .1.3.6.1.4.1.1916.2.

This comment has been minimized.

@laf

laf May 2, 2017

Member

Is it worth adding:

sysDescr_except:
        - Release_Master

Or are we relying on the order of the files?

@laf

laf May 2, 2017

Member

Is it worth adding:

sysDescr_except:
        - Release_Master

Or are we relying on the order of the files?

This comment has been minimized.

@murrant

murrant May 3, 2017

Member

I have been relying on the order being alphabetical.

@murrant

murrant May 3, 2017

Member

I have been relying on the order being alphabetical.

@laf laf merged commit 5e790ee into librenms:master May 3, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:fix-xos-extremeware branch May 3, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.