New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alart-log many devices, load selects from ajax #6557

Merged
merged 1 commit into from May 3, 2017

Conversation

Projects
None yet
5 participants
@murrant
Member

murrant commented May 3, 2017

fixes: #5264

The issue was all the string concatenation...

But I decided to try loading the select via ajax. Seems ok. We could just use something like select2. Opinions? Use this approach or load at page load.
I was able to reduce the loading of the 4000 select items from 1.6s to 0.6s on my laptop by optimizing the sql.

I added 4000 devices to my database to check this :)

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fix: load selects from ajax
fixes: #5264

The issue was all the string concatenation...

But I decided to try loading the select via ajax. Seems ok.  We could just use something like select2.  Opinions? Use this approach or load at page load.
I was able to reduce the loading of the 4000 select items from 1.6s to 0.6s on my laptop by optimizing the sql.

I added 4000 devices to my database to check this :)
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot May 3, 2017

Thank you for submitting a PR @murrant! We have found the following @f0o, @benwa and @laf based on the history of these files to review this PR.

mention-bot commented May 3, 2017

Thank you for submitting a PR @murrant! We have found the following @f0o, @benwa and @laf based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 3, 2017

Auto-Deploy finished, Test PR at http://6557.ci.librenms.org or https://6557.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier May 3, 2017

The inspection completed: 1 updated code elements

scrutinizer-notifier commented May 3, 2017

The inspection completed: 1 updated code elements

@murrant murrant added the Question label May 3, 2017

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant May 3, 2017

Member

perhaps I should separate these out. Fix the bug in one PR, submit the ajax select loading in another.

Member

murrant commented May 3, 2017

perhaps I should separate these out. Fix the bug in one PR, submit the ajax select loading in another.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 3, 2017

Member

Don't think you need to separate it out.

Member

laf commented May 3, 2017

Don't think you need to separate it out.

@laf laf merged commit 2b3ca49 into librenms:master May 3, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:ajax-selects branch May 3, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.