New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Improve Juniper MSS Support #6565

Merged
merged 3 commits into from May 16, 2017

Conversation

Projects
None yet
5 participants
@Rosiak
Contributor

Rosiak commented May 3, 2017

Add the following sensors

  • Processor
  • Mempool
  • State

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

feature: Improve Juniper MSS Support
Add the following sensors
- Processor
- Mempool
- State
@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant May 3, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented May 3, 2017

CLA assistant check
All committers have signed the CLA.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 3, 2017

Auto-Deploy finished, Test PR at http://6565.ci.librenms.org or https://6565.ci.librenms.org

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 3, 2017

Member

Would it be possible to change the snmp_gets to multi_gets?

Member

laf commented May 3, 2017

Would it be possible to change the snmp_gets to multi_gets?

@Rosiak

This comment has been minimized.

Show comment
Hide comment
@Rosiak

Rosiak May 7, 2017

Contributor

Will see if I can get it done during the next week, my time is very limited at the moment.

Contributor

Rosiak commented May 7, 2017

Will see if I can get it done during the next week, my time is very limited at the moment.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 16, 2017

Auto-Deploy finished, Test PR at http://6565.ci.librenms.org or https://6565.ci.librenms.org

@Rosiak

This comment has been minimized.

Show comment
Hide comment
@Rosiak

Rosiak May 16, 2017

Contributor

Should be fixed now.

Contributor

Rosiak commented May 16, 2017

Should be fixed now.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 16, 2017

Member

Thanks, I've pushed a change to move all mibs to juniper dir (we should move junos + others). Can be merged when checks complete

Member

laf commented May 16, 2017

Thanks, I've pushed a change to move all mibs to juniper dir (we should move junos + others). Can be merged when checks complete

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 16, 2017

Auto-Deploy finished, Test PR at http://6565.ci.librenms.org or https://6565.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier May 16, 2017

The inspection completed: No new issues

scrutinizer-notifier commented May 16, 2017

The inspection completed: No new issues

@laf laf merged commit c40b762 into librenms:master May 16, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@Rosiak Rosiak deleted the Rosiak:juniper-mss-improvements branch Nov 15, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.