New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alerting: Added option to enable/disable option for sending alerts to normal users #6590

Merged
merged 6 commits into from May 15, 2017

Conversation

Projects
None yet
6 participants
@laf
Member

laf commented May 5, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #6499

By default, adding a normal user and assigning them a device means they will get alerts for this and can't disable it. With this you can now enable / disable that ability.

I've chosen to default this off as I think that should be the fresh install option, this will obviously stop alerts for users who now expect the old way is how it should be for which I've put a notification in. Overall I'm not fussed if we default to on or off but just felt that we shouldn't default to what was the old (broken imho) way and we should do it properly.

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot May 5, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @benwa and @f0o based on the history of these files to review this PR.

mention-bot commented May 5, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @benwa and @f0o based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 5, 2017

Auto-Deploy finished, Test PR at http://6590.ci.librenms.org or https://6590.ci.librenms.org

@murrant

murrant approved these changes May 5, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 5, 2017

Auto-Deploy finished, Test PR at http://6590.ci.librenms.org or https://6590.ci.librenms.org

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 5, 2017

Member

Actually added schema file now!

Member

laf commented May 5, 2017

Actually added schema file now!

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 5, 2017

Auto-Deploy finished, Test PR at http://6590.ci.librenms.org or https://6590.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 5, 2017

Auto-Deploy finished, Test PR at http://6590.ci.librenms.org or https://6590.ci.librenms.org

@f0o

I'd default it to true to maintain current behavior

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 6, 2017

Member

Feel free to push the change to my branch

Member

laf commented May 6, 2017

Feel free to push the change to my branch

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 6, 2017

Member

If you do change it to default on, please remove the update from notifications as that's no longer relevant.

Member

laf commented May 6, 2017

If you do change it to default on, please remove the update from notifications as that's no longer relevant.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant May 6, 2017

Member

How about different defaults for new and existing installs.

Member

murrant commented May 6, 2017

How about different defaults for new and existing installs.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 6, 2017

Member

That would require adding it as false to config.php.default and means users can't just use the webui to make changes to the option.

We should just pick one way or the other.

Member

laf commented May 6, 2017

That would require adding it as false to config.php.default and means users can't just use the webui to make changes to the option.

We should just pick one way or the other.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 13, 2017

Member

bump

Member

laf commented May 13, 2017

bump

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 15, 2017

Auto-Deploy finished, Test PR at http://6590.ci.librenms.org or https://6590.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier May 15, 2017

The inspection completed: No new issues

scrutinizer-notifier commented May 15, 2017

The inspection completed: No new issues

@laf laf merged commit 612186d into librenms:master May 15, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.