New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Added support for Terra sti410C #6598

Merged
merged 4 commits into from May 13, 2017

Conversation

Projects
None yet
6 participants
@maciejkaczkowski
Contributor

maciejkaczkowski commented May 6, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant May 6, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented May 6, 2017

CLA assistant check
All committers have signed the CLA.

@maciejkaczkowski maciejkaczkowski changed the title from Maciejkaczkowski to newdevice: Added support for Terra sti410C May 6, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 6, 2017

Auto-Deploy finished, Test PR at http://6598.ci.librenms.org or https://6598.ci.librenms.org

Show outdated Hide outdated includes/definitions/sti410c.yaml
Show outdated Hide outdated includes/polling/os/sti410c.inc.php
renamed sti410c to terra, added support for sti440 and recognition fo…
…r sda410C, sta410C, saa410C, sdi410C, sai410C, ttd440, ttx410C, tdx410C, sdi480
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 6, 2017

Auto-Deploy finished, Test PR at http://6598.ci.librenms.org or https://6598.ci.librenms.org

@@ -0,0 +1,10 @@
os: terra

This comment has been minimized.

@laf

laf May 7, 2017

Member

That's one extreme to the other :)

Does this cover all terra devices?

@laf

laf May 7, 2017

Member

That's one extreme to the other :)

Does this cover all terra devices?

This comment has been minimized.

@maciejkaczkowski

maciejkaczkowski May 8, 2017

Contributor

It covers channel processor devices (DVB-T to IP, DVB-S to DVB-C etc, index 5-10 and 14-18).
All have custom embbeded OS (different for each model), I made tests only for sti410 (9) and sti440 (18). Each device has its own MIBs available after purchase. Only version and serial number are under the same OID.

It doesn't cover products with index:
1 - OD120 - optical receiver - discontinued
2 - MO411 - optical transmitter (other purpose)
3 - MO4x8 - optical transmitter (other purpose - not DVB processor)
4 - UC412 - can't find any info
11 - S2C16 - Similar GUI to sti410, should also work
12 - OT001M - can't find any info
13 - S2C16P - Similar GUI to sti410, should also work

@maciejkaczkowski

maciejkaczkowski May 8, 2017

Contributor

It covers channel processor devices (DVB-T to IP, DVB-S to DVB-C etc, index 5-10 and 14-18).
All have custom embbeded OS (different for each model), I made tests only for sti410 (9) and sti440 (18). Each device has its own MIBs available after purchase. Only version and serial number are under the same OID.

It doesn't cover products with index:
1 - OD120 - optical receiver - discontinued
2 - MO411 - optical transmitter (other purpose)
3 - MO4x8 - optical transmitter (other purpose - not DVB processor)
4 - UC412 - can't find any info
11 - S2C16 - Similar GUI to sti410, should also work
12 - OT001M - can't find any info
13 - S2C16P - Similar GUI to sti410, should also work

@laf

The logo should be the same dimensions width + height (square).

You can use the one you have in html/images/logos/terra.svg

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 10, 2017

Auto-Deploy finished, Test PR at http://6598.ci.librenms.org or https://6598.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 10, 2017

Auto-Deploy finished, Test PR at http://6598.ci.librenms.org or https://6598.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier May 10, 2017

The inspection completed: 1 new issues

scrutinizer-notifier commented May 10, 2017

The inspection completed: 1 new issues

@maciejkaczkowski

This comment has been minimized.

Show comment
Hide comment
@maciejkaczkowski

maciejkaczkowski May 10, 2017

Contributor

Sorry for the last commit, it should be separate pull request - I don't know how to remove auto commit to current thread.

Contributor

maciejkaczkowski commented May 10, 2017

Sorry for the last commit, it should be separate pull request - I don't know how to remove auto commit to current thread.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 13, 2017

Auto-Deploy finished, Test PR at http://6598.ci.librenms.org or https://6598.ci.librenms.org

@laf laf merged commit cef1b72 into librenms:master May 13, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 13, 2017

Member

Thanks for the pull request.

I reverted your last commit by the way as it was for another device, can you submit that as a different pull request please?

Member

laf commented May 13, 2017

Thanks for the pull request.

I reverted your last commit by the way as it was for another device, can you submit that as a different pull request please?

@maciejkaczkowski maciejkaczkowski deleted the maciejkaczkowski:maciejkaczkowski branch May 13, 2017

@maciejkaczkowski

This comment has been minimized.

Show comment
Hide comment
@maciejkaczkowski

maciejkaczkowski May 13, 2017

Contributor

Ok, Thank you. I will make few updates and create another request.

Contributor

maciejkaczkowski commented May 13, 2017

Ok, Thank you. I will make few updates and create another request.

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.