New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MySQL app graphs fail with rrdcached #6608

Merged
merged 1 commit into from May 8, 2017

Conversation

Projects
None yet
5 participants
@murrant
Member

murrant commented May 8, 2017

Do not send -1 values when we set the minimum as 0. Send the proper U for non-values.
fixes: #6223

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fix: MySQL app graphs with rrdcached
Do not send -1 values when we set the minimum as 0.  Send the proper U for non-values.
fixes: #6223
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot May 8, 2017

Thank you for submitting a PR @murrant! We have found the following @laf based on the history of these files to review this PR.

mention-bot commented May 8, 2017

Thank you for submitting a PR @murrant! We have found the following @laf based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented May 8, 2017

Auto-Deploy finished, Test PR at http://6608.ci.librenms.org or https://6608.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier May 8, 2017

The inspection completed: No new issues

scrutinizer-notifier commented May 8, 2017

The inspection completed: No new issues

@murrant murrant changed the title from fix: MySQL app graphs with rrdcached to fix: MySQL app graphs fail with rrdcached May 8, 2017

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant May 8, 2017

Member

Looks good so far, you'll notice the graphs containing bad values fail stil:
image

Member

murrant commented May 8, 2017

Looks good so far, you'll notice the graphs containing bad values fail stil:
image

@laf laf merged commit 379176c into librenms:master May 8, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:issue-6223 branch May 8, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.