New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: page/graph load speed: part 1 #6611

Merged
merged 3 commits into from May 10, 2017

Conversation

Projects
None yet
5 participants
@murrant
Member

murrant commented May 9, 2017

Speed up load_all_os() by caching the full $config['os'] array
Function time goes from 1.13648s -> 0.00073s
The cache is updated during discovery, but only if it is >22hrs old.
Additionally, the cache is not used and a full yaml load is forced if the cache is >24hrs old.
The cache time is controlled by $config['os_def_cache_time'], I don't see any reason anyone would change that time.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fix: page/graph load speed: part 1
Speed up load_all_os() by caching the full $config['os'] array
Function time goes from 1.13648s -> 0.00073s
The cache is updated during discovery, but only if it is >22hrs old.
Additionally, the cache is not used and a full yaml load is forced if the cache is >24hrs old.
The cache time is controlled by $config['os_def_cache_time'], I don't see any reason anyone would change that time.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot May 9, 2017

Thank you for submitting a PR @murrant! We have found the following @laf, @paulgear and @BarbarossaTM based on the history of these files to review this PR.

mention-bot commented May 9, 2017

Thank you for submitting a PR @murrant! We have found the following @laf, @paulgear and @BarbarossaTM based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 9, 2017

Auto-Deploy finished, Test PR at http://6611.ci.librenms.org or https://6611.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 9, 2017

Auto-Deploy finished, Test PR at http://6611.ci.librenms.org or https://6611.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 9, 2017

Auto-Deploy finished, Test PR at http://6611.ci.librenms.org or https://6611.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier May 9, 2017

The inspection completed: 2 updated code elements

scrutinizer-notifier commented May 9, 2017

The inspection completed: 2 updated code elements

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 9, 2017

Member

lgtm, leaving to run overnight on my test install

Member

laf commented May 9, 2017

lgtm, leaving to run overnight on my test install

@laf laf merged commit b6e18db into librenms:master May 10, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:cache-os-defs branch May 10, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.