New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Added more health information for APC units #6619

Merged
merged 5 commits into from May 17, 2017

Conversation

Projects
None yet
5 participants
@laf
Member

laf commented May 9, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #5385

I've fixed two current states that didn't show the translation. The change will actually break graphs but as these are only states then I've not put a notification in.

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot May 9, 2017

Thank you for submitting a PR @laf! We have found the following @HenocKA, @murrant and @InsaneSplash based on the history of these files to review this PR.

mention-bot commented May 9, 2017

Thank you for submitting a PR @laf! We have found the following @HenocKA, @murrant and @InsaneSplash based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 9, 2017

Auto-Deploy finished, Test PR at http://6619.ci.librenms.org or https://6619.ci.librenms.org

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 15, 2017

Member

Confirmed working in the issue. @librenms/reviewers worth a notification for state graphs changing in this?

Member

laf commented May 15, 2017

Confirmed working in the issue. @librenms/reviewers worth a notification for state graphs changing in this?

@Rosiak

This comment has been minimized.

Show comment
Hide comment
@Rosiak

Rosiak May 16, 2017

Contributor

Meh, personally I don't care about state graphs as they typically are pretty static.
So IMO not worth it.

Contributor

Rosiak commented May 16, 2017

Meh, personally I don't care about state graphs as they typically are pretty static.
So IMO not worth it.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 16, 2017

Member

Rebased.

Yeah they aren't as useful day to day, it's mainly the alerting that is of importance.

Member

laf commented May 16, 2017

Rebased.

Yeah they aren't as useful day to day, it's mainly the alerting that is of importance.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 16, 2017

Auto-Deploy finished, Test PR at http://6619.ci.librenms.org or https://6619.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier May 16, 2017

The inspection completed: 1 updated code elements

scrutinizer-notifier commented May 16, 2017

The inspection completed: 1 updated code elements

@laf laf merged commit 895801d into librenms:master May 17, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:fix/issue-5385 branch May 17, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.