New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix radius debug mode #6623

Merged
merged 1 commit into from May 10, 2017

Conversation

Projects
None yet
6 participants
@olivierbeytrison
Contributor

olivierbeytrison commented May 10, 2017

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot May 10, 2017

Thank you for submitting a PR @olivierbeytrison! We have found the following @laf and @murrant based on the history of these files to review this PR.

mention-bot commented May 10, 2017

Thank you for submitting a PR @olivierbeytrison! We have found the following @laf and @murrant based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 10, 2017

Auto-Deploy finished, Test PR at http://6623.ci.librenms.org or https://6623.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier May 10, 2017

The inspection completed: No new issues

scrutinizer-notifier commented May 10, 2017

The inspection completed: No new issues

@laf laf merged commit 472d15a into librenms:master May 10, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@olivierbeytrison olivierbeytrison deleted the olivierbeytrison:fix-radius-debug branch May 10, 2017

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant May 12, 2017

Member

Hah, I fixed this in my auth branch and it caused a merge conflict!

Member

murrant commented May 12, 2017

Hah, I fixed this in my auth branch and it caused a merge conflict!

@olivierbeytrison

This comment has been minimized.

Show comment
Hide comment
@olivierbeytrison

olivierbeytrison May 12, 2017

Contributor

Sorry :D

Contributor

olivierbeytrison commented May 12, 2017

Sorry :D

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant May 12, 2017

Member

No worries, just amazed that the bug was fixed twice at about the same time when it has been there for months.

Member

murrant commented May 12, 2017

No worries, just amazed that the bug was fixed twice at about the same time when it has been there for months.

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.