New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Rittal LCP Liquid Cooling Package #6626

Merged
merged 6 commits into from Jul 5, 2017

Conversation

Projects
None yet
4 participants
@FTBZ
Contributor

FTBZ commented May 10, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926


  • ENTITY-SENSOR-MIB is used to returns data without specific support
  • Humidity includes things like the SD Card usage or valve opening because it's values in percent

screen shot 2017-05-10 at 11 52 45

  • Temperatures have wrong divisors, but I don't know how to correct this because this is a OID stating with the same values

temperature

  • Voltage divisors are wrong but changing this in the functions.php file has no effect

screen shot 2017-05-10 at 11 52 49

  • Cooling Capacity isn't a Power information, but it's in Power sensors because this is a value in kW

screen shot 2017-05-10 at 11 52 51

  • Latest thing is that a new sensor type exists : l/min and it's not yet supported, it can be used to view the water flow in the cooling unit

For me, it's not a real problem. I prefer to have the information in bad categories than not to have it at all. Advices are welcome.

@laf laf added the Blocker 🚫 label May 10, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 10, 2017

Auto-Deploy finished, Test PR at http://6626.ci.librenms.org or https://6626.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 10, 2017

Auto-Deploy finished, Test PR at http://6626.ci.librenms.org or https://6626.ci.librenms.org

@FTBZ

This comment has been minimized.

Show comment
Hide comment
@FTBZ

FTBZ May 23, 2017

Contributor

Always waiting for an answer from Rittal about these problems to be sure to take the correct way.

Contributor

FTBZ commented May 23, 2017

Always waiting for an answer from Rittal about these problems to be sure to take the correct way.

@FTBZ

This comment has been minimized.

Show comment
Hide comment
@FTBZ

FTBZ Jun 8, 2017

Contributor

OK, finally got a response from Rittal about this. ENTITY-SENSOR-MIB/RFC 3433 isn't yet supported but OIDs are used... It's planned but I've no release date.

So what's the best way here? In my opinion problems are not really critical, I prefer to have these informations on the wrong sensor type rather than not having them.

Contributor

FTBZ commented Jun 8, 2017

OK, finally got a response from Rittal about this. ENTITY-SENSOR-MIB/RFC 3433 isn't yet supported but OIDs are used... It's planned but I've no release date.

So what's the best way here? In my opinion problems are not really critical, I prefer to have these informations on the wrong sensor type rather than not having them.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 5, 2017

Auto-Deploy finished, Test PR at http://6626.ci.librenms.org or https://6626.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 5, 2017

Auto-Deploy finished, Test PR at http://6626.ci.librenms.org or https://6626.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 5, 2017

Auto-Deploy finished, Test PR at http://6626.ci.librenms.org or https://6626.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jul 5, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Jul 5, 2017

The inspection completed: No new issues

@laf laf merged commit 39d3639 into librenms:master Jul 5, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.