Updated install docs - specifically cron setup #663

Merged
merged 1 commit into from Mar 25, 2015

Projects

None yet

3 participants

@laf
Member
laf commented Mar 25, 2015

I've put this PR together for a couple of reasons:

  1. Symlinking the cron seems to be hit and miss for some due to file and owner permissions.
  2. If you edit the cron (which is expected to enable billing) then the branch becomes dirty. Not this isn't an issue for those who understand git but we have to imagine most people just install and forget. This would then stop a git pull from being done.

Don't worry about the PR too much, close it if you don't think we should be recommending it this way (if it gets closed, someone needs to update the install docs anyway as 1 out of 3 recommends it to be this way).

@f0o f0o merged commit 0926001 into librenms:master Mar 25, 2015

1 check passed

Scrutinizer No new issues
Details
@paulgear
Member

Maybe we need to think about adding --no-edit to the git pull in the update code.

@laf
Member
laf commented Mar 26, 2015

Was trying to work out what you meant @paulgear, you mean doing a git pull --no-edit. We set that by default at work as we run our own branch.

Reading the docs it's not recommended but I don't see it as being an issue (config option so people can turn it off if they like).

@laf
Member
laf commented Mar 26, 2015

p.s want us to roll this change back and do the --no-edit?

@paulgear
Member

The advantage of running --no-edit is that it means that local edits don't stop updates from happening; the disadvantage is that it can create merge conflicts if people have edited the same files, which can break their installation. So I think maybe --no-edit is a bad idea and I shouldn't have mentioned it. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment