I've put this PR together for a couple of reasons:
Don't worry about the PR too much, close it if you don't think we should be recommending it this way (if it gets closed, someone needs to update the install docs anyway as 1 out of 3 recommends it to be this way).
Updated install docs to specify copying librenms.cron rather than sym…
Maybe we need to think about adding --no-edit to the git pull in the update code.
Was trying to work out what you meant @paulgear, you mean doing a git pull --no-edit. We set that by default at work as we run our own branch.
Reading the docs it's not recommended but I don't see it as being an issue (config option so people can turn it off if they like).
p.s want us to roll this change back and do the --no-edit?
The advantage of running --no-edit is that it means that local edits don't stop updates from happening; the disadvantage is that it can create merge conflicts if people have edited the same files, which can break their installation. So I think maybe --no-edit is a bad idea and I shouldn't have mentioned it. :-)