New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Added script (scripts/test-template.php) to test alert templates #6631

Merged
merged 3 commits into from May 13, 2017

Conversation

Projects
None yet
5 participants
@laf
Member

laf commented May 10, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Allows users to test a template against a rule and device. If it's a triggered rule then it will populate fault data.

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot May 10, 2017

Thank you for submitting a PR @laf! We have found the following @benwa, @murrant and @f0o based on the history of these files to review this PR.

mention-bot commented May 10, 2017

Thank you for submitting a PR @laf! We have found the following @benwa, @murrant and @f0o based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented May 10, 2017

Auto-Deploy finished, Test PR at http://6631.ci.librenms.org or https://6631.ci.librenms.org

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 11, 2017

Member

Updated now, I've actually moved all the functions out of alerts.php, seems pointless to have them in there.

Member

laf commented May 11, 2017

Updated now, I've actually moved all the functions out of alerts.php, seems pointless to have them in there.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented May 11, 2017

Auto-Deploy finished, Test PR at http://6631.ci.librenms.org or https://6631.ci.librenms.org

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant May 12, 2017

Member

Looks good.

Probably need to add a note in the documentation.

Member

murrant commented May 12, 2017

Looks good.

Probably need to add a note in the documentation.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented May 13, 2017

Auto-Deploy finished, Test PR at http://6631.ci.librenms.org or https://6631.ci.librenms.org

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 13, 2017

Member

Docs updated (slight move around as well)

Member

laf commented May 13, 2017

Docs updated (slight move around as well)

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier May 13, 2017

The inspection completed: 12 updated code elements

scrutinizer-notifier commented May 13, 2017

The inspection completed: 12 updated code elements

@murrant murrant merged commit 0338734 into librenms:master May 13, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:feature/community-1183 branch May 13, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.