New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: modest speedup to database config population #6636

Merged
merged 1 commit into from May 13, 2017

Conversation

Projects
None yet
5 participants
@murrant
Member

murrant commented May 12, 2017

Page/Graph speedup part 3

use references to assign values into the config array more efficiently, prevents a lot of memory churn caused by the recursive approach

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

refactor: modest speedup to database config population
use references to assign values into the config array more efficiently, prevents a lot of memory churn caused by the recursive approach
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot May 12, 2017

Thank you for submitting a PR @murrant! We have found the following @f0o based on the history of these files to review this PR.

mention-bot commented May 12, 2017

Thank you for submitting a PR @murrant! We have found the following @f0o based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 12, 2017

Auto-Deploy finished, Test PR at http://6636.ci.librenms.org or https://6636.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier May 12, 2017

The inspection completed: 48 new issues, 1 updated code elements

scrutinizer-notifier commented May 12, 2017

The inspection completed: 48 new issues, 1 updated code elements

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant May 12, 2017

Member

I dumped the config with both this and the previous code and the arrays were equal (and array_diff was empty). Some things were in different order, but that doesn't affect anything.

Member

murrant commented May 12, 2017

I dumped the config with both this and the previous code and the arrays were equal (and array_diff was empty). Some things were in different order, but that doesn't affect anything.

@laf laf merged commit 595e75b into librenms:master May 13, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:mergedb-walk branch May 13, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.