New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: HPE RT3000 UPS #6638

Merged
merged 4 commits into from May 16, 2017

Conversation

Projects
None yet
6 participants
@marcuspink
Contributor

marcuspink commented May 12, 2017

Initial support for HP(E) R/T3000 UPS which is basically a rebranded EATON 5P UPS.
That's why MG-SNMP-UPS-MIB is used instead of a specific HPE MIB.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot May 12, 2017

Thank you for submitting a PR @marcuspink! We have found the following @murrant, @HenocKA and @laf based on the history of these files to review this PR.

Thank you for submitting a PR @marcuspink! We have found the following @murrant, @HenocKA and @laf based on the history of these files to review this PR.

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant May 12, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented May 12, 2017

CLA assistant check
All committers have signed the CLA.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
Show outdated Hide outdated includes/polling/os/hpe-rtups.inc.php
@@ -0,0 +1,8 @@
<?php
$version = trim(snmp_get($device, 'upsmgIdentFirmwareVersion.0', '-OQv', 'MG-SNMP-UPS-MIB'), '" ');

This comment has been minimized.

@laf

laf May 13, 2017

Member

Thanks for the PR.

Can you change all of the snmp_get() calls here to one snmp_get_multi_oid(). See includes/polling/os/extendair.inc.php as an example

@laf

laf May 13, 2017

Member

Thanks for the PR.

Can you change all of the snmp_get() calls here to one snmp_get_multi_oid(). See includes/polling/os/extendair.inc.php as an example

@laf

Just one change and it's all good I think.

Thanks :)

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier May 16, 2017

The inspection completed: No new issues

The inspection completed: No new issues

@laf laf merged commit 5b9623d into librenms:master May 16, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 16, 2017

Member

image

Member

laf commented May 16, 2017

image

@laf laf referenced this pull request May 19, 2017

Merged

newdevice: Added detection for Cisco EPC devices #6690

1 of 1 task complete
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.