New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Added support for Geist PDU #6646

Merged
merged 1 commit into from May 17, 2017

Conversation

Projects
None yet
3 participants
@laf
Member

laf commented May 15, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #6622

@laf laf added the Device 🖥 label May 15, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier May 15, 2017

The inspection completed: No new issues

scrutinizer-notifier commented May 15, 2017

The inspection completed: No new issues

-
sysObjectId:
- .1.3.6.1.4.1.21239.
sysDescr_except:

This comment has been minimized.

@murrant

murrant May 16, 2017

Member

Isn't this unneeded since geist-pdu is first?

@murrant

murrant May 16, 2017

Member

Isn't this unneeded since geist-pdu is first?

This comment has been minimized.

@laf

laf May 16, 2017

Member

I like to be safe, removing anyway.

@laf

laf May 16, 2017

Member

I like to be safe, removing anyway.

This comment has been minimized.

@laf

laf May 16, 2017

Member

Actually phpunit fails when I do. So leaving in place

@laf

laf May 16, 2017

Member

Actually phpunit fails when I do. So leaving in place

This comment has been minimized.

@murrant

murrant May 17, 2017

Member

That's strange, makes it seem like I'm missing something...

@murrant

murrant May 17, 2017

Member

That's strange, makes it seem like I'm missing something...

This comment has been minimized.

@murrant

murrant May 17, 2017

Member

I removed it locally and tests ran fine. I'm not bothered by it though.

@murrant

murrant May 17, 2017

Member

I removed it locally and tests ran fine. I'm not bothered by it though.

This comment has been minimized.

@laf

laf May 17, 2017

Member

I'm also now getting errors when run pre-commit about other OS' so it could be my local install :/

@laf

laf May 17, 2017

Member

I'm also now getting errors when run pre-commit about other OS' so it could be my local install :/

@murrant murrant merged commit e223ec3 into librenms:master May 17, 2017

2 of 3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:newdevice/issue-6622 branch May 17, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.