New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better Lancom LCOS detection, added LCOS-MIB #6651

Merged
merged 2 commits into from May 17, 2017

Conversation

Projects
None yet
5 participants
@marcuspink
Contributor

marcuspink commented May 16, 2017

Added detection for all current Lancom LCOS devices. Added LCOS-MIB.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot May 16, 2017

Thank you for submitting a PR @marcuspink! We have found the following @laf based on the history of these files to review this PR.

Thank you for submitting a PR @marcuspink! We have found the following @laf based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@laf

Couple of changes needed on this one.

Show outdated Hide outdated includes/polling/os/lcos.inc.php
* @copyright 2016 Neil Lathwood
* @author Neil Lathwood <neil@lathwood.co.uk>
*/
$lcos_data = snmp_get_multi_oid($device, 'lcsFirmwareVersionTableEntrySerialNumber.1 lcsFirmwareVersionTableEntryVersion.1 lcsFirmwareVersionTableEntryModule.1', '-OQs', 'LCOS-MIB');

This comment has been minimized.

@laf

laf May 16, 2017

Member

You should add your own copyright.

@laf

laf May 16, 2017

Member

You should add your own copyright.

Show outdated Hide outdated includes/definitions/lcos.yaml
@@ -6,7 +6,9 @@ over:
- { graph: device_bits, text: 'Device Traffic' }
- { graph: device_processor, text: 'CPU Usage' }
- { graph: device_mempool, text: 'Memory Usage' }
register_mibs:
LCOS-MIB: LCOS-MIB

This comment has been minimized.

@laf

laf May 16, 2017

Member

I think this is wrong, I assume you just want to tell things where the mib is?

You should do:

mib_dir:
    - lancom

@laf

laf May 16, 2017

Member

I think this is wrong, I assume you just want to tell things where the mib is?

You should do:

mib_dir:
    - lancom

This comment has been minimized.

@laf

laf May 16, 2017

Member

And move the mib you added into mibs/lancom/

@laf

laf May 16, 2017

Member

And move the mib you added into mibs/lancom/

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier May 17, 2017

The inspection completed: 54 new issues, 22 updated code elements

The inspection completed: 54 new issues, 22 updated code elements

@laf

laf approved these changes May 17, 2017

@laf laf merged commit 26c17de into librenms:master May 17, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.