New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Arris C4c #6662

Merged
merged 14 commits into from Jun 1, 2017

Conversation

Projects
None yet
6 participants
@maciejkaczkowski
Contributor

maciejkaczkowski commented May 17, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Added also temperature sensors for Arris C4

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot May 17, 2017

Thank you for submitting a PR @maciejkaczkowski! We have found the following @laf based on the history of these files to review this PR.

mention-bot commented May 17, 2017

Thank you for submitting a PR @maciejkaczkowski! We have found the following @laf based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 17, 2017

Auto-Deploy finished, Test PR at http://6662.ci.librenms.org or https://6662.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 17, 2017

Auto-Deploy finished, Test PR at http://6662.ci.librenms.org or https://6662.ci.librenms.org

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 17, 2017

Member

Last thing, just needs a unit test file: http://docs.librenms.org/Developing/os/Test-Units/

Member

laf commented May 17, 2017

Last thing, just needs a unit test file: http://docs.librenms.org/Developing/os/Test-Units/

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant May 17, 2017

Member

Your svg icon needs to be cropped, there should not be any padding around it. In Inkscape, Document Properties -> Resize page to content...

Member

murrant commented May 17, 2017

Your svg icon needs to be cropped, there should not be any padding around it. In Inkscape, Document Properties -> Resize page to content...

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 24, 2017

Auto-Deploy finished, Test PR at http://6662.ci.librenms.org or https://6662.ci.librenms.org

@laf

All good except the OS logos must be square.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 25, 2017

Auto-Deploy finished, Test PR at http://6662.ci.librenms.org or https://6662.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 25, 2017

Auto-Deploy finished, Test PR at http://6662.ci.librenms.org or https://6662.ci.librenms.org

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant May 25, 2017

Member

@laf that is not true anymore all logos must have no padding.

Member

murrant commented May 25, 2017

@laf that is not true anymore all logos must have no padding.

@maciejkaczkowski

This comment has been minimized.

Show comment
Hide comment
@maciejkaczkowski

maciejkaczkowski May 25, 2017

Contributor

@laf @murrant should I fix it or can you remove last two commits (to d9155d8 )?

Contributor

maciejkaczkowski commented May 25, 2017

@laf @murrant should I fix it or can you remove last two commits (to d9155d8 )?

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 26, 2017

Auto-Deploy finished, Test PR at http://6662.ci.librenms.org or https://6662.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier May 26, 2017

The inspection completed: No new issues

scrutinizer-notifier commented May 26, 2017

The inspection completed: No new issues

@murrant murrant merged commit 5283501 into librenms:master Jun 1, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.