New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: marking invalid ports as deleted in discovery #6665

Merged
merged 1 commit into from May 17, 2017

Conversation

Projects
None yet
4 participants
@murrant
Member

murrant commented May 17, 2017

There seem to be other issues in this file, such as $ports_l is never defined...

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fix: fix marking invalid ports as deleted in discovery
There seem to be other issues in this file, such as $ports_l is never defined...
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 17, 2017

Auto-Deploy finished, Test PR at http://6665.ci.librenms.org or https://6665.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier May 17, 2017

The inspection completed: No new issues

scrutinizer-notifier commented May 17, 2017

The inspection completed: No new issues

@laf laf merged commit 8d1b7d5 into librenms:master May 17, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:port-disc-fix-sql branch May 18, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.