New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HipChat v2 API + Color Changes #6669

Merged
merged 1 commit into from May 17, 2017

Conversation

Projects
None yet
6 participants
@jackson-tim
Contributor

jackson-tim commented May 17, 2017

Added support for the HipChat V2 API (it detects if "v2" is in the API URL) and also changed the default coloring so any non-recovery/reboot messages get colored as red.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

HipChat v2 API + Color Changes
Added support for the HipChat V2 API (it detects if "v2" is in the API URL) and also changed the default coloring so any non-recovery/reboot messages get colored as red.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot May 17, 2017

Thank you for submitting a PR @jackson-tim! We have found the following @laf, @supertylerc and @khobbits based on the history of these files to review this PR.

mention-bot commented May 17, 2017

Thank you for submitting a PR @jackson-tim! We have found the following @laf, @supertylerc and @khobbits based on the history of these files to review this PR.

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant May 17, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented May 17, 2017

CLA assistant check
All committers have signed the CLA.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 17, 2017

Auto-Deploy finished, Test PR at http://6669.ci.librenms.org or https://6669.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier May 17, 2017

The inspection completed: No new issues

scrutinizer-notifier commented May 17, 2017

The inspection completed: No new issues

@laf laf merged commit 390dd0b into librenms:master May 17, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is not signed yet.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.