Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: rrdtool web settings #6698
DO NOT DELETE THIS TEXT
If you would like to test this pull request then please run:
to fully implement web settings (or db config) the db configs should overwrite the global ones (from files).
discovered this issue when tried to change the rrdtool bin from web but it was still using the defaults.
I'm against this 100%. Breaking anything is best avoided but when this can break rrdtool then that's a pretty bad thing to do.
v2 is aiming to prioritise db config over config.php but I don't believe we should change v1, it's been that way since db config was added and I don't know anyone else yet caught out by this.
The best option would be to just make an ajax call for the config options and test if they exist in config.php
@laf ... i run this and doesn't break anything. without it settings the rrdtool path in web is useless, being overwriting always by default.inc.php or config.php (and then the docs should be changed as they say the preferred way to set rrdtool path is via web not via config.php).