New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make login form more mobile-friendly #6707

Merged
merged 2 commits into from May 24, 2017

Conversation

Projects
None yet
6 participants
@peelman
Contributor

peelman commented May 22, 2017

Disable autocomplete, autocorrect, autocapitalize, and spellcheck on username and password input forms.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

make login form more mobile-friendly
Disable autocomplete, autocorrect, autocapitalize, and spellcheck on username and password input forms.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot May 22, 2017

Thank you for submitting a PR @peelman! We have found the following @arjitc, @murrant and @Rosiak based on the history of these files to review this PR.

mention-bot commented May 22, 2017

Thank you for submitting a PR @peelman! We have found the following @arjitc, @murrant and @Rosiak based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 22, 2017

Auto-Deploy finished, Test PR at http://6707.ci.librenms.org or https://6707.ci.librenms.org

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 22, 2017

Member

What's wrong with autocomplete on the username field?

Also, does this stop browser saved logins working at all?

Member

laf commented May 22, 2017

What's wrong with autocomplete on the username field?

Also, does this stop browser saved logins working at all?

@peelman

This comment has been minimized.

Show comment
Hide comment
@peelman

peelman May 22, 2017

Contributor

In my case, on iOS, the input field defaults to capitalizing the first character. So you end up with Npeelman instead of npeelman. If you have a username that is spelled like a common word, it may autocorrect it every time (which mine will do occasionally on systems where my username is just 'peelman').

AFAIK, it doesn't affect saved browser logins. It only affects how browsers treat the keyboard entry on those inputs.

Contributor

peelman commented May 22, 2017

In my case, on iOS, the input field defaults to capitalizing the first character. So you end up with Npeelman instead of npeelman. If you have a username that is spelled like a common word, it may autocorrect it every time (which mine will do occasionally on systems where my username is just 'peelman').

AFAIK, it doesn't affect saved browser logins. It only affects how browsers treat the keyboard entry on those inputs.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 22, 2017

Member

I'm fine with all the others (like auto capital, etc), just wondering if the actual auto-complete should be left on for usernames?

Member

laf commented May 22, 2017

I'm fine with all the others (like auto capital, etc), just wondering if the actual auto-complete should be left on for usernames?

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant May 22, 2017

Member

Also, I don't think those attributes are needed when type="password" so you can remove them all there.

Also, autocomplete=off makes it so the browser will not remember what was entered into that field. I'd suggest removing it. The other three look great, thanks :)

Member

murrant commented May 22, 2017

Also, I don't think those attributes are needed when type="password" so you can remove them all there.

Also, autocomplete=off makes it so the browser will not remember what was entered into that field. I'd suggest removing it. The other three look great, thanks :)

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 22, 2017

Member

murrant summed up what I was trying to say :)

Member

laf commented May 22, 2017

murrant summed up what I was trying to say :)

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 23, 2017

Auto-Deploy finished, Test PR at http://6707.ci.librenms.org or https://6707.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier May 23, 2017

The inspection completed: No new issues

scrutinizer-notifier commented May 23, 2017

The inspection completed: No new issues

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant May 24, 2017

Member

Thanks!

Member

murrant commented May 24, 2017

Thanks!

@murrant murrant merged commit 88e71a5 into librenms:master May 24, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.