New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dashboard slowness with offline browser #6718

Merged
merged 13 commits into from Jun 2, 2017

Conversation

Projects
None yet
5 participants
@slashdoom
Contributor

slashdoom commented May 24, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot May 24, 2017

Thank you for submitting a PR @slashdoom! We have found the following @f0o, @laf and @murrant based on the history of these files to review this PR.

mention-bot commented May 24, 2017

Thank you for submitting a PR @slashdoom! We have found the following @f0o, @laf and @murrant based on the history of these files to review this PR.

@slashdoom

This comment has been minimized.

Show comment
Hide comment
@slashdoom

slashdoom May 24, 2017

Contributor

Not sure if this a good idea or not...

In my environment, the browser I use to access LibreNMS doesn't have internet access. This makes the dashboard page load extremely slow. It seems like only the globe widget needs this Google JS file which I don't use so seems like a good speed fix.

Similar to issue #2124.

Contributor

slashdoom commented May 24, 2017

Not sure if this a good idea or not...

In my environment, the browser I use to access LibreNMS doesn't have internet access. This makes the dashboard page load extremely slow. It seems like only the globe widget needs this Google JS file which I don't use so seems like a good speed fix.

Similar to issue #2124.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 24, 2017

Auto-Deploy finished, Test PR at http://6718.ci.librenms.org or https://6718.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier May 24, 2017

The inspection completed: No new issues

scrutinizer-notifier commented May 24, 2017

The inspection completed: No new issues

@laf laf merged commit fbf157c into librenms:master Jun 2, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.