New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask people to contribute documentation #6739

Merged
merged 3 commits into from Jun 4, 2017

Conversation

Projects
None yet
7 participants
@trs80
Contributor

trs80 commented May 27, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot May 27, 2017

Thank you for submitting a PR @trs80! We have found the following @laf, @JamesonFinney and @Andreser based on the history of these files to review this PR.

Thank you for submitting a PR @trs80! We have found the following @laf, @JamesonFinney and @Andreser based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant May 30, 2017

Member

Good addition, but I'm not sure if the content is right.

Member

murrant commented May 30, 2017

Good addition, but I'm not sure if the content is right.

@paulgear

This comment has been minimized.

Show comment
Hide comment
@paulgear

paulgear May 31, 2017

Member

Seems reasonable to me; maybe "Some features exist ..." would be better?

Member

paulgear commented May 31, 2017

Seems reasonable to me; maybe "Some features exist ..." would be better?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 31, 2017

Member

I think something like:

Documentation. Documentation can always be improved and every little helps. Not all features are currently documented or documented well, speeling mistakes exist along with additional FAQs.
Member

laf commented May 31, 2017

I think something like:

Documentation. Documentation can always be improved and every little helps. Not all features are currently documented or documented well, speeling mistakes exist along with additional FAQs.
Ask people to contribute documentation v2
Revised wording, also s/Git Hub/GitHub/ and misc acronym capitalisation.
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jun 4, 2017

The inspection completed: No new issues

The inspection completed: No new issues

@laf laf merged commit de314b2 into librenms:master Jun 4, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jun 4, 2017

Member

Thanks :)

Member

laf commented Jun 4, 2017

Thanks :)

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.