New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add column title #6747

Merged
merged 2 commits into from May 30, 2017

Conversation

Projects
None yet
5 participants
@SLMitch
Contributor

SLMitch commented May 29, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Hi,
On a bgp view for a device
(for example /device/device=6/tab=routing/proto=bgp/ )
title and field are not alligned

capture d ecran de 2017-05-29 18-15-13

I check in the source code, in fract an AFI column is missing on title.

Regards

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot May 29, 2017

Thank you for submitting a PR @SLMitch! We have found the following @murrant, @laf and @adaniels21487 based on the history of these files to review this PR.

Thank you for submitting a PR @SLMitch! We have found the following @murrant, @laf and @adaniels21487 based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
Change column name
Change the column name to `Family` to be consistent
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

@murrant murrant merged commit dbaad70 into librenms:master May 30, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier May 30, 2017

The inspection completed: No new issues

The inspection completed: No new issues

@SLMitch SLMitch deleted the SLMitch:issue-6747 branch Jun 6, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.