New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Irc templates #6758

Merged
merged 5 commits into from Jun 8, 2017

Conversation

Projects
None yet
7 participants
@Olen
Contributor

Olen commented May 30, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

This will change the behaviour of the irc bot, so it will display info based on the alert-temaplates.
Be aware that this might lead to excessive flooding if the templates are big.
Use {if transport == irc} in the templates to format them for irc

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot May 30, 2017

Thank you for submitting a PR @Olen! We have found the following @murrant, @deutor and @laf based on the history of these files to review this PR.

mention-bot commented May 30, 2017

Thank you for submitting a PR @Olen! We have found the following @murrant, @deutor and @laf based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented May 30, 2017

Auto-Deploy finished, Test PR at http://6758.ci.librenms.org or https://6758.ci.librenms.org

@f0o

f0o approved these changes May 31, 2017

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant May 31, 2017

Member

Probably, should add something to the documentation so people are aware :)

Member

murrant commented May 31, 2017

Probably, should add something to the documentation so people are aware :)

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 31, 2017

Member

@Olen you should just remove the old code you commented out, git maintains history so we can always go back to it if needs be.

I'd also say we should notify people of this change, we have quite a few users of irc alerting. Please edit https://github.com/librenms/librenms.github.io/blob/master/notifications.rss (you can see previous changes to that file to see what to change). Set the date one week in advance and we will merge this on that date.

Member

laf commented May 31, 2017

@Olen you should just remove the old code you commented out, git maintains history so we can always go back to it if needs be.

I'd also say we should notify people of this change, we have quite a few users of irc alerting. Please edit https://github.com/librenms/librenms.github.io/blob/master/notifications.rss (you can see previous changes to that file to see what to change). Set the date one week in advance and we will merge this on that date.

@laf laf added the Blocker 🚫 label Jun 2, 2017

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jun 2, 2017

Member

Needs merging on the 8th of June.

Member

laf commented Jun 2, 2017

Needs merging on the 8th of June.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Jun 6, 2017

Auto-Deploy finished, Test PR at http://6758.ci.librenms.org or https://6758.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jun 6, 2017

The inspection completed: 1 updated code elements

scrutinizer-notifier commented Jun 6, 2017

The inspection completed: 1 updated code elements

@laf laf merged commit 3dd6628 into librenms:master Jun 8, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf removed the Blocker 🚫 label Jun 8, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.