New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more coloring and make it easier to colorize messages #6759

Merged
merged 5 commits into from Jun 2, 2017

Conversation

Projects
None yet
5 participants
@Olen
Contributor

Olen commented May 30, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

This is just a start. I will probably add some more coloring in other parts of the code, and also possibly make it optional(?)

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot May 30, 2017

Thank you for submitting a PR @Olen! We have found the following @murrant, @deutor and @laf based on the history of these files to review this PR.

mention-bot commented May 30, 2017

Thank you for submitting a PR @Olen! We have found the following @murrant, @deutor and @laf based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented May 30, 2017

Auto-Deploy finished, Test PR at http://6759.ci.librenms.org or https://6759.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented May 31, 2017

Auto-Deploy finished, Test PR at http://6759.ci.librenms.org or https://6759.ci.librenms.org

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 31, 2017

Member

You've got some issues to fix from Travis: https://travis-ci.org/librenms/librenms/jobs/237836319 These are all style changes really, we adopt the psr-2 standard.

Member

laf commented May 31, 2017

You've got some issues to fix from Travis: https://travis-ci.org/librenms/librenms/jobs/237836319 These are all style changes really, we adopt the psr-2 standard.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Jun 1, 2017

Auto-Deploy finished, Test PR at http://6759.ci.librenms.org or https://6759.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jun 1, 2017

The inspection completed: 1 updated code elements

scrutinizer-notifier commented Jun 1, 2017

The inspection completed: 1 updated code elements

@laf laf merged commit d4bd4b8 into librenms:master Jun 2, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.