New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C.H.I.P. power monitor #6763

Merged
merged 16 commits into from Jun 4, 2017

Conversation

Projects
None yet
5 participants
@drid
Contributor

drid commented May 31, 2017

Power readings for C.H.I.P
Adds soltage and current readings for battery, ACIN and VBUS.
Adds battery charge percentage.
DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant May 31, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented May 31, 2017

CLA assistant check
All committers have signed the CLA.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 31, 2017

Auto-Deploy finished, Test PR at http://6763.ci.librenms.org or https://6763.ci.librenms.org

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 31, 2017

Member

Why aren't the new files just in the linux file? The issue with doing it the way you have is that if we add an os called chip then it will conflict.

Member

laf commented May 31, 2017

Why aren't the new files just in the linux file? The issue with doing it the way you have is that if we add an os called chip then it will conflict.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 31, 2017

Auto-Deploy finished, Test PR at http://6763.ci.librenms.org or https://6763.ci.librenms.org

drid added some commits May 24, 2017

Better device detection
Added AXP209 temperature readings
Merge branch 'chip-battery-voltage' of github.com:drid/librenms into …
…chip-battery-voltage

Conflicts:
	includes/discovery/sensors/charge/linux.inc.php
	includes/discovery/sensors/current/linux.inc.php
	includes/discovery/sensors/voltage/linux.inc.php
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jun 2, 2017

Member

Last thing for me, if $index conflicts with previous code then the sensors won't be discovered. As this is using numerical OIDs then use double index for the discover_sensor() code (116.2) as an example.

Member

laf commented Jun 2, 2017

Last thing for me, if $index conflicts with previous code then the sensors won't be discovered. As this is using numerical OIDs then use double index for the discover_sensor() code (116.2) as an example.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 2, 2017

Auto-Deploy finished, Test PR at http://6763.ci.librenms.org or https://6763.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 2, 2017

Auto-Deploy finished, Test PR at http://6763.ci.librenms.org or https://6763.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jun 2, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Jun 2, 2017

The inspection completed: No new issues

@laf laf merged commit f7c5aee into librenms:master Jun 4, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@drid drid deleted the drid:chip-battery-voltage branch Jun 4, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.