New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update graphs to use safer RRD check #6781

Merged
merged 1 commit into from Jun 5, 2017

Conversation

Projects
None yet
5 participants
@bfg-agoulet
Contributor

bfg-agoulet commented Jun 4, 2017

Graphs that were using file_exists() to check for the presence of RRD
files now use rrdtool_check_rrd_exists() instead. This is a fix for
distributed poller configurations that are running rrdcached on a
different host.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Updated graphs to use safer RRD check
Graphs that were using `file_exists()` to check for the presence of RRD
files now use `rrdtool_check_rrd_exists()` instead. This is a fix for
distributed poller configurations that are running `rrdcached` on a
different host.
@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Jun 4, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Jun 4, 2017

CLA assistant check
All committers have signed the CLA.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 4, 2017

Auto-Deploy finished, Test PR at http://6781.ci.librenms.org or https://6781.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jun 4, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Jun 4, 2017

The inspection completed: No new issues

@laf laf merged commit 8c4efc8 into librenms:master Jun 5, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is not signed yet.
Details
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jun 5, 2017

Member

image
Thanks for contributing

Member

laf commented Jun 5, 2017

image
Thanks for contributing

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

@bfg-agoulet bfg-agoulet deleted the bfg-agoulet:check-rrd-exists-update branch Aug 8, 2018

@bfg-agoulet bfg-agoulet restored the bfg-agoulet:check-rrd-exists-update branch Aug 8, 2018

@bfg-agoulet bfg-agoulet deleted the bfg-agoulet:check-rrd-exists-update branch Aug 8, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.